New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small typo #28

Closed

junming259 opened this issue Jun 7, 2017 · 2 comments

Contributor

junming259 commented Jun 7, 2017 •

edited

Thanks for sharing your code, excellent job! I found a small typo in your code.

https://github.com/vanhuyz/CycleGAN-TensorFlow/blob/master/ops.py#L84

conv2 = tf.nn.conv2d(padded2, weights1, strides=[1, 1, 1, 1], padding='VALID')

It should be weights2 instead of weights1, right?

Thanks

Owner

vanhuyz commented Jun 8, 2017

Yes, weights2 for sure. Please send me a pull request!

Owner

vanhuyz commented Jun 8, 2017

Solved with #29.

vanhuyz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment