Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch too big #1603

Closed
lyubomir-popov opened this issue Feb 28, 2018 · 3 comments
Closed

Switch too big #1603

lyubomir-popov opened this issue Feb 28, 2018 · 3 comments
Labels
WG: Validated Validate working group proposals

Comments

@lyubomir-popov
Copy link
Contributor

2. Pattern proposal/amendment

The switch component is rather big compared to other switches in material design / ios etc. We have some complaints about it being too big in maas (https://bugs.launchpad.net/maas/+bug/1751899), so I think it is worth considering making it smaller.

Is this a proposal or an amendment?

  • Amendment

If amendment, what is the name of the pattern to be amended?

Visual

Provide a screenshot or link to prototype of your pattern proposal.

Context

In what context will the pattern be used?

State

Does this pattern have state? If so, what are the different states (e.g. accordion with closed/open states)?

Progressive enhancement

A pattern should be designed small screen first. How does this pattern scale up?
How will this pattern degrade on less competent browsers?

@lyubomir-popov lyubomir-popov added the WG: Proposal Working group proposals label Feb 28, 2018
@lyubomir-popov
Copy link
Contributor Author

Update: I've played around with it, and although it can be made smaller, the text inside makes it look too tight. Can we omitt the On / Off? iOS / Android switches don't seem to have it, and there's an optional label in the pattern to clarify what it is doing.

@kwm14
Copy link
Contributor

kwm14 commented Mar 19, 2018

Agreed in working group

  • convert switcher to checkbox
  • we can remove on/off text

@kwm14 kwm14 added WG: Validated Validate working group proposals and removed WG: Proposal Working group proposals labels Mar 19, 2018
@kwm14
Copy link
Contributor

kwm14 commented May 15, 2018

Fixed in v1.7.0 release 💯

@kwm14 kwm14 closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WG: Validated Validate working group proposals
Projects
None yet
Development

No branches or pull requests

2 participants