DiscussionModel BeforeGetCount event not fired

[bleistivt]

When GetCount(); is called without arguments (like in DiscussionsController->Index) the counts are calculated from the CountDiscussions cache of the categories, rendering the BeforeGetCount event useless:

vanilla/applications/vanilla/models/class.discussionmodel.php

Lines 1058 to 1072 in 6942247

	if (!$Wheres || (count($Wheres) == 1 && isset($Wheres['d.CategoryID']))) {
	// Grab the counts from the faster category cache.
	if (isset($Wheres['d.CategoryID'])) {
	$CategoryIDs = (array)$Wheres['d.CategoryID'];
	if ($Perms === FALSE)
	$CategoryIDs = array();
	elseif (is_array($Perms))
	$CategoryIDs = array_intersect($CategoryIDs, $Perms);
	if (count($CategoryIDs) == 0) {
	return 0;
	} else {
	$Perms = $CategoryIDs;
	}
	}

[linc]

Are you requesting an earlier hook to use? I'm reluctant to move an existing hook, and I don't wanna make a new one for no reason.

[bleistivt]

The problem is that there is no way to modify the discussion counts in some cases.

You can always modify the discussions fetched using beforeGet, but beforeGetCount sometimes just doesn't work, which is inconsistent.
This will also lead to a faulty pager showing a wrong number of pages.

The $Wheres eventarg is not used by the non-cache logic. Thus moving the hook above the hightlighted piece of code I linked to should be safe.

I'll be happy to submit a pull request.

[linc]

A PR is always best. 👍

[DaazKu]

PR is under review.