Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab action from text box inconsistent #3344

Closed
linc opened this issue Nov 26, 2015 · 2 comments · Fixed by #4349
Closed

Tab action from text box inconsistent #3344

linc opened this issue Nov 26, 2015 · 2 comments · Fixed by #4349
Assignees
Milestone

Comments

@linc
Copy link
Contributor

linc commented Nov 26, 2015

On discussions, hitting tab (from comment box) will take you to the Add Comment button, so you can type your comment, hit tab and enter, done. In private messages, hitting tab takes you to the Markdown (or whichever format) link instead of send message.

@ntravis
Copy link

ntravis commented Jan 30, 2016

Also, if you edit a comment, hitting tab from the comment results first in going to the box for adding a new comment. Hitting tab again takes from you from the "new comment" box back to the Save Comment button for the edit.

@ntravis
Copy link

ntravis commented May 12, 2016

Following up:
addmessage.php#L32 needs tab index 1
addmessage.php#L34 needs tab index 2

to correct the original problem.

The second issue: The editcomment.php would need to alter the tab index of the parent using JS(?) upon opening to make the tabindex of the "normal" comment box at the bottom equal to 3 and the Add Comment equal to 4. editcomment.php is already making its own comment tabindex=1 and save=2, but the browser is making the original take precedence AFAIK. Hitting save comment could restore the original state of the normal comment box and Add Comment button on exit. If you wanted to avoid hardcoding, you could bring in tabindex value of the original box, set the editcomment to that, then set original box to tabindex+2, and similarly for the Save comment vs Add Comment buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants