Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically quote all usernames in mentions that might require quoting #4658

Closed
initvector opened this issue Oct 17, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@initvector
Copy link
Contributor

Usernames with spaces are automatically quoted when performing a mention. There are other usernames, like those with periods, which currently require quoting to be properly formatted, but aren't automatically quoted.

A couple possible solutions:

  1. The requires_quotation check could be expanded to include additional characters.
  2. The way mentions are formatted in posts could be more accommodating to these types of usernames.
@initvector initvector changed the title Quote all usernames mentions that might require quoting Automatically quote all usernames mentions that might require quoting Oct 17, 2016
@initvector initvector changed the title Automatically quote all usernames mentions that might require quoting Automatically quote all usernames in mentions that might require quoting Oct 17, 2016
@DaazKu
Copy link
Contributor

DaazKu commented Oct 17, 2016

Why aren't we just requiring quoting for all usernames that does not match /[^\w-]/.
We escape double quotes and we are done once and for all with that issue.

@linc linc added this to the Sprint 27 milestone Oct 24, 2016
@linc linc modified the milestones: 2017-Q1-1, Sprint 27 Dec 4, 2016
@linc linc modified the milestones: 2017-Q1-3, 2017-Q1-1 Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants