Fix for GetUnread to include unread discussions without comments #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetUnread didn't show unread discussions without comments. First fix (1ab2895) didn't respect permissions - thanks @peregrine for raising that issue (#1871) This fix includes unread discussions without comments and adds a permission check to the function
R-J
referenced
this pull request
Apr 28, 2014
GetUnread was not showing new discussions without any comment. Fixed that.
|
Thanks! I am actually going to hold this for the first 2.1 patch because I need to test this and we're way past beta. |
R-J
changed the title
|
To get this in, I'd need two things: the merge conflicts resolved (by merging 2.1 back into this PR) and to make sure the equivalent fix is in master so we don't have a regression for 2.3. |
|
Sorry, I'm a git noob and I do not know how to merge something back into a PR. The code change is very small, shall I "simply" create a new PR against the current branch? |
|
Oh, you just push the changes to the same branch. A pull request is not specific commits, it is branch-to-branch, so changes to the branch are auto-added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetUnread didn't show unread discussions without comments. First fix didn't respect permissions - thanks @peregrine-web for raising that issue
This fix includes unread discussions without comments and adds a permission check to the function