Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working #2

Open
nikkii94 opened this issue Dec 20, 2019 · 1 comment
Open

Not working #2

nikkii94 opened this issue Dec 20, 2019 · 1 comment

Comments

@nikkii94
Copy link

nikkii94 commented Dec 20, 2019

Hello! I installed this extension from Chrome Store but when I try to download subtitle but nothing happens.
I always get the following error:

netflix-subtitle-downloader.js:127 Uncaught (in promise) TypeError: Cannot destructure property 'titleP' of 'subCache[getMovieID(...)]' as it is undefined.
    at _download (netflix-subtitle-downloader.js:127)
    at HTMLLIElement.downloadThis (netflix-subtitle-downloader.js:153)

netflix-subtitle-downloader.js:101 Uncaught (in promise) TypeError: Cannot read property 'downloadUrls' of undefined
    at processSubInfo (netflix-subtitle-downloader.js:101)
    at processMessage (netflix-subtitle-downloader.js:173)

Can you help solve this? Thank you!

@greeven
Copy link

greeven commented Feb 6, 2020

Had the same problem and found the culprit in netflix-subtitle-downloader.js on line 17.

//old line
const WEBVTT = 'webvtt-lssdh-ios8';

// new line
const WEBVTT = 'dfxp-ls-sdh';

This should fix it (I don't use this repo but it seems to use the same underlying javascript.)

Maybe I find the time to make this change directly in this repository. (Haven't done that yet, so it would take me some time now I don't have.)

Hope that helps. ;)

Oh and be aware: the structure of the subtitles file has changed (if you have a consequent script running a regex against it). ;P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants