Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] re-publish on npm #8

Closed
meneman opened this issue Oct 21, 2018 · 1 comment
Closed

[request] re-publish on npm #8

meneman opened this issue Oct 21, 2018 · 1 comment

Comments

@meneman
Copy link
Contributor

meneman commented Oct 21, 2018

Hi vankop,

When installing your package via npm, it comes with its own copy of josdejong/jsoneditor. Since your last publish on npm is 8 month ago, it lacks cool new features from josdejong/jsoneditor. ( even so your package is compatible with them)

At the moment, one has to to build jsoneditor-react from source (or maybe npm install from github-link) in order to have it use a newer build of josdejong/jsoneditor.

@vankop
Copy link
Owner

vankop commented Oct 22, 2018

@meneman I decided to publish 1.0.0 version with jsoneditor as peerDependency so if you want to install latest versions run:

npm install --save jsoneditor jsoneditor-react

and it doesn't affects users with version less than 1.0.0 due to semver policy.

@vankop vankop closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants