Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button hides pop up but it shows soft keyboard dismissing afterwards #124

Closed
jorgevalbuena56 opened this issue May 18, 2017 · 17 comments

Comments

@jorgevalbuena56
Copy link

It is possible to dismiss the soft keyboard before dismissing the pop up? The way it is right now you can tell that the soft keyboard was behind even if I never showed it on the screen.

the version that I am using is the last one and the device is a Samsung galaxy note 5 with lollipop.

Thank you for filing an issue. If this is a bug that you want to report, please take the time to provide some information:

  • Version of the library:
  • Affected devices:
  • Affected versions:

Screenshot(s) showing the issue and reprodution steps are appreciated.


@vanniktech
Copy link
Owner

Can you try 0.5.0-SNAPSHOT?

@jorgevalbuena56
Copy link
Author

Where is that snapshot, I can't find it in the gradle repo

I have this in my gradle file:
compile 'com.vanniktech:emoji-ios:0.5.0-SNAPSHOT'

@vanniktech
Copy link
Owner

You need to add the snapshot url as a maven repo: https://oss.sonatype.org/content/repositories/snapshots

@jorgevalbuena56
Copy link
Author

jorgevalbuena56 commented May 19, 2017

Now I am getting this error:

Error:(78) No resource identifier found for attribute 'emojiSize'

@vanniktech
Copy link
Owner

Yes that one has been removed. Please use setLineHeight now.

@jorgevalbuena56
Copy link
Author

I changed it and I still getting the same error:
<com.vanniktech.emoji.EmojiEditText
android:id="@+id/chat_edit_text1"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="bottom"
android:layout_marginStart="12dp"
android:layout_marginEnd="12dp"
android:hint="@string/type_your_message"
android:inputType="textMultiLine"
android:textSize="16sp"
android:textColorHint="@color/hint_type"
android:background="@null"
android:text="@{viewModel}"
android:onClick="@{viewModel.onMessageTypeClicked()}"
app:setLineHeight="26sp">

</com.vanniktech.emoji.EmojiEditText>

Error:(78) No resource identifier found for attribute 'setLineHeight'

@vanniktech
Copy link
Owner

Oh sorry. Use the setLineHeight method from TextView. Otherwise you can also have a look at the sample that changes the emoji size.

@jorgevalbuena56
Copy link
Author

There's not setLineHeight method in TextView neither in the EditText, I think you meant setLineSpacing ??

@vanniktech
Copy link
Owner

That's how the sample changes the size.

@jorgevalbuena56
Copy link
Author

So much of a hassle just to try a completely different thing...

@b3nnee
Copy link

b3nnee commented May 25, 2017

Had the same problem as you did. You should use... android:textAppearance

android:textAppearance = "@style/TextAppearance.AppCompat.Medium"

@vanniktech
Copy link
Owner

@jorgevalbuena56 is this now resolved?

@jorgevalbuena56
Copy link
Author

This is not resolved, I still can see the keyboard dismissing after the pop up. It will never work if u show the keyboard and then the pop up. I was able to do a workaround with the back button but still is not the desire effect.

@vanniktech
Copy link
Owner

Can you post a video or gif that shows the issue? And explain what you'd expect?

@jorgevalbuena56
Copy link
Author

I only expect that if I tap the emoji button, never see a keyboard again, even if I hit the back button. Once the view switches to the emoji view pager, the Softkeyboard must be completely hidden, instead it's overlapped by the view pager

@vanniktech
Copy link
Owner

@jorgevalbuena56 just merged a PR that adds the emoji size functionality back to 0.5.0-SNAPSHOT (it should be out within an hour). Please report back.

@vanniktech
Copy link
Owner

I'll close this. Also I created #148 to track the Emoji size issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants