Fix dialog calculations

[mario]

The emoji keyboard wasn't working as expected when used inside a dialog. This PR fixes that.

Please test both regular and dialog to make sure I didn't break anything :)

Please note that I've based this on an AndroidX branch, but it could easily be back-ported, if needed.

[vanniktech]

I should probably know this but since when do we have that animation? :D It's only present for me in the main screen and not for the dialog.

Can't we slide it in from the top to the bottom without this skewing?

[mario]

Since you merged my PRs that added the animations :P

And yes, the dialog doesn't have it, though it could if you want! :D

It's an option btw, so you don't have to use it but it's there as a sample.

[vanniktech]

Yeah, I know it's configurable. Maybe we can choose a better default for the demo app nonetheless though. :D

[vanniktech]

Maybe wait for @rubengees approval here since he usually has a device or two that needs testing.

[mario]

@vanniktech I look forward to your PR :P

[vanniktech]

@mario well played!

[mario]

@rubengees did you maybe have the time to check this out?

[mario]

@rubengees I know you're around here somewhere :p

[rubengees]

@mario Yeah, will look into it now :)

[rubengees]

The code changes look fine and work perfectly in the normal case. The picker for the dialog is like this though (on my usual device OP5T Stock@9.0):

[mario]

Hm but this is exactly what this code was supposed to fix, and did for me. But will check once again

…

On Wed, 6 Mar 2019, 00:20 Ruben Gees, ***@***.***> wrote: ***@***.**** requested changes on this pull request. The code changes look fine and work perfectly in the normal case. The picker for the dialog is like this though (on my usual device OP5T ***@***.*** ): [image: screenshot_20190306-001700] <https://user-images.githubusercontent.com/8021265/53844263-71a05f00-3fa5-11e9-885f-090fb1a5dde9.jpg> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#346 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWsq5FNG50ojj96INBmYaVvIFqtundks5vTvuhgaJpZM4bCkLu> .

[rubengees]

Hmm, maybe I checked the wrong branch? Will also confirm tomorrow.

[vanniktech]

What's the state here?

[mario]

Pending another check by both me and @rubengees.

[rubengees]

@mario Just double checked, I can still reproduce such weird behaviour. :/

[vanniktech]

@mario do you want to pick this up again?

[mario]

Yes, don't close it.

…

On Tue, 30 Apr 2019, 17:40 Niklas Baudy, ***@***.***> wrote: @mario <https://github.com/mario> do you want to pick this up again? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#346 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABNMVQW6OTDIMX7DXRGOTPTBSABANCNFSM4GYKILXA> .

[vanniktech]

@mario friendly ping since now I'm active :D

[mario]

As long as its friendly xD

…

On Tue, 10 Sep 2019, 17:22 Niklas Baudy, ***@***.***> wrote: @mario <https://github.com/mario> friendly ping since now I'm active :D — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#346?email_source=notifications&email_token=AAABNMQWBWXKETIPIDNK4X3QI63U7A5CNFSM4GYKILXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LPUNA#issuecomment-529988148>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABNMSU6DXWNOQLILPKUMLQI63U7ANCNFSM4GYKILXA> .

[vanniktech]

[mario]

Closing in favor of a new PR.