New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Change Request] Algorithm decorators #440
Comments
It might be a good idea to also accept the old prefixes ( |
Instead of prefixes we could also consider using: @data
@client
@socket
def method(data, client, socker, args*, kwargs**):
pass Decorators register which signature belongs to which method, which then can be read by the vantage6/vantage6-client/vantage6/tools/dispatch_rpc.py Lines 63 to 64 in fa0ab4f
|
Note that with the above, we will be letting go of the distinction between 'master' and 'RPC' methods, so there would no longer be a need for the prefixes |
This should be done by giving an argument to the decorator, that should somehow be fed back to the way in which the algorithm is called |
Lets test this when we create our first algorithm |
I tested this using the average:v4 algorithm the |
Description
In the algorithms, there are a couple of methods that we want to rename. The best is to do this in v4.0, so that we don't face compatibility issues later. Renames should include:
central_
~~master
anymoreRPC_
as that is unclear (maybe simplylocal_
)Note that this list is not exhaustive:
The text was updated successfully, but these errors were encountered: