Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Change Request] Replace set-output method from the Github actions #474

Closed
frankcorneliusmartin opened this issue Jan 12, 2023 · 2 comments · Fixed by #601
Closed

[Change Request] Replace set-output method from the Github actions #474

frankcorneliusmartin opened this issue Jan 12, 2023 · 2 comments · Fixed by #601
Assignees
@bartvanb @frankcorneliusmartin
Labels
change Internal change

Comments

@frankcorneliusmartin
Copy link
Contributor

Description
Github actions complains about some of the commands we use:

[github-release](https://github.com/vantage6/vantage6/actions/runs/3900643513/jobs/6661546997)
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: marvinpinto/action-automatic-releases@latest. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
@frankcorneliusmartin frankcorneliusmartin added the change Internal change label Jan 12, 2023
@github-actions github-actions bot added the New label Jan 12, 2023
@bartvanb bartvanb mentioned this issue Jan 13, 2023
Merged
@bartvanb
Copy link
Member

Fix for 1 of the 4 warnings in the linked PR.

The rest seems to be related to the action from 'marvinpinto' we're using. There is an open PR there that would probably solve the deprecation warnings: https://github.com/marvinpinto/action-automatic-releases/pull/2/files

@bartvanb bartvanb mentioned this issue Jan 26, 2023
Merged
@frankcorneliusmartin
Copy link
Contributor Author

Unfortunately this has not been resolved yet. See build logs for 3.8.0rc3:
image

Pushed it to release 3.9

@bartvanb bartvanb mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartvanb bartvanb

@frankcorneliusmartin frankcorneliusmartin

Labels
change Internal change
Projects
Sprints
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use different github action to create a Github release, since marvinp… vantage6/vantage6
2 participants
@bartvanb @frankcorneliusmartin