Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pulling image is now based on push_time which is not updated if image is identical #507

Closed
bartvanb opened this issue Jan 25, 2023 · 0 comments · Fixed by #617
Closed
Assignees
Labels
bug Something isn't working

Comments

@bartvanb
Copy link
Member

Describe the bug
In pull_if_newer(), we pull the image if the remote timestamp is newer than the local one. Recently, we changed this (#482), and based the timestamp on the push time.

It can occur that the local and remote image are identical, but that the remote push timestamp is newer. Then, the 'newer' remote image is pulled over and over again without ever updating the timestamp. This should be achieved somehow so that no pulls are attempted.

Note that when the images are identical, the pull time is short, so this issue is not very pressing for that reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants