Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-channel .ome.tiff #13

Closed
ArtemSokolov opened this issue Jul 26, 2021 · 2 comments · Fixed by #14
Closed

Add support for multi-channel .ome.tiff #13

ArtemSokolov opened this issue Jul 26, 2021 · 2 comments · Fixed by #14
Labels
enhancement New feature or request

Comments

@ArtemSokolov
Copy link

Consider adding support for multi-channel .ome.tiff, by re-parameterizing
--nuclear-image <file.tif> --membrane-image <file.tif>
to
--image <file.ome.tif> --nuclear-channel <int> --membrane-channel <int>

As a possible feature, allow for multiple indices to be specified, renaming the parameters to --nuclear-channels and --membrane-channels accordingly.

Example code for reading .ome.tiff and other formats:
https://github.com/HMS-IDAC/UnMicst/blob/340a31de8873fa247ea502e778ef14acee56984e/UnMicst2.py#L754-L764

@willgraf
Copy link
Contributor

This issue is fixed in the first release 0.1.0.

--nuclear-channel and --membrane-channel default to 0 (expecting --nuclear-image and --membrane-image to be single channel), but both can accept multiple channels which get summed together into a single channel (e.g. "membrane" channel).

For images that contain both membrane and nuclear channels, just pass the same file path to both --nuclear-image and --membrane-image and set the corresponding channel(s).

Please re-open this issue if you don't think it's closed. And please make a new issue for anything you'd like to see added or improved!

@FloWuenne
Copy link

Hi @willgraf ,

I would like to re-open this issue and suggest the following change:

Change the default for --membrane-image to :
"If not passed, and --membrane-channel is not -1, --nuclear-image is used instead.

Instead of the current way of reading two separate files (one for nuclear and one for membrane), this would only read a large multi-channel image once and would be more in line with the idea of using large, multi-channel images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants