Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocaleIdentifier should use "-" instead of "_" #12

Closed
th-mustache-dk opened this issue Mar 24, 2022 · 1 comment
Closed

LocaleIdentifier should use "-" instead of "_" #12

th-mustache-dk opened this issue Mar 24, 2022 · 1 comment

Comments

@th-mustache-dk
Copy link

According to the RFC, locale identifiers in headers uses "-" to separate language from country code

https://httpwg.org/specs/rfc7231.html#header.accept-language

Therefore the code should be corrected to use "-"

Perhaps some logic from https://github.com/matsoftware/accept-language-parser can be used.

@miroslavkovac
Copy link
Contributor

Hi @th-mustache-dk, the "_" in locale identifiers were from iOS world :) Please check the version 4.2.0 where this is now fixed. Thanks for reporting an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants