-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the Sign In With Apple provider :) #41
Comments
I definitely want to do this soon. I can't guarantee when it will be done with my schedule, but I'll do it as soon as I get a chance. |
Hi @calebkleveter. Just wanted to give a small poke on this so you don't forget ;) |
Really good info here about the server side part of this: https://blog.curtisherbert.com/so-theyve-signed-in-with-apple-now-what/ |
So picking this up as I've implemented in a couple of client projects here - what do you want from Imperial for this? For doing it on iOS devices Imperial is not the way to do it since it's basically just a JWT |
Nada. I posted this way back when because you had originally told me to use Imperial when I was first asking you about this at WWDC, @0xTim |
😅 well I'm going to reopen it because there's definitely scope to add SIWA as a provider to Imperial, it just needs to be made clear that it's for web (and android) only, iOS should just use JWT |
Here's another good source of info that may ultimately be useful when implementing this: https://sarunw.com/posts/sign-in-with-apple-3/ |
Hey @calebkleveter, any ETA on this one? |
I'm so sorry. 😢 I really want to implement this but time constraints are not helping. I haven't done any work on this at all. |
I've been looking at this and it doesn't really fit with Imperial right now. To start with, Apple's OAuth flow is non-existent until they decide to open it up. Secondly there's no real OAuth flow as Imperial understands it. You use the JS button which eventually calls a route on your app with the data. This provides a JWT token which you can use Vapor's JWT library to verify in a single line and there's not much else to do. There's a good write up on RW, here's the relevant part. That's basically what Imperial would need to provide and most of it is vey app specific and would be delegated to Imperial's completion handler. I'm going to close this for now |
Pretty please.
The text was updated successfully, but these errors were encountered: