Skip to content
This repository has been archived by the owner on Mar 30, 2024. It is now read-only.

Numeric values like 0.0x are deserialized as 0.x0 #75

Closed
tygriffin opened this issue May 20, 2018 · 4 comments
Closed

Numeric values like 0.0x are deserialized as 0.x0 #75

tygriffin opened this issue May 20, 2018 · 4 comments

Comments

@tygriffin
Copy link

When deserializing from the Postgres numeric datatype, values of the format 0.0x are coming out as 0.x0. So for example 0.08 is deserialized to 0.80.

@tygriffin
Copy link
Author

https://github.com/vapor/postgresql appears to have the same issue.

@vzsg
Copy link
Member

vzsg commented May 22, 2018

Fixed in #76 and version 2.1.2.

@vzsg vzsg closed this as completed May 22, 2018
@dmonagle
Copy link
Contributor

Hi @vzsg, my pleasure in catching this. I don't know if you are also involved in the vapor 3 code for postgresql, however the bug is also present there. Totally different code, but the same logic applies. I've opened a pull request over there too. If you aren't a reviewer over there, hopefully @tanner0101 or somebody similar can approve that one ASAP.

@vzsg
Copy link
Member

vzsg commented May 22, 2018

Well, I can always get myself involved. I made a new point release there with your fix too, thanks.

(Funny thing, my very first contribution to Vapor was fixing the same number handling issue – in v1's JSON parsing.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants