Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access control on setOption and resolve #125

Closed
kydos opened this issue Apr 28, 2017 · 3 comments
Closed

Access control on setOption and resolve #125

kydos opened this issue Apr 28, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@kydos
Copy link

kydos commented Apr 28, 2017

Hello,

I wonder why the operations listed below have internal access control:

  • InternetAddress.resolve
  • Descriptor.(setOption | getOption | setBoolOption | getBoolOption)

The get/set Option operations are handy to change manipulate the socket options, for instance to join/leave a multicast group as well as to deal with the ADDR/PORT reuse.

Likewise the resolve operation on the InternetAddress is kind of essential to send a datagram over an unconnected UDP socket.

Ciao, Kydos

@tanner0101 tanner0101 added the bug label May 1, 2017
@tanner0101 tanner0101 added this to the 2.0 milestone May 1, 2017
@tanner0101 tanner0101 self-assigned this May 1, 2017
@tanner0101
Copy link
Collaborator

I'll look into publicizing those methods for 2.0.

@kydos
Copy link
Author

kydos commented May 3, 2017

Great thanks!

@tanner0101
Copy link
Collaborator

We've moved to a different setup now in Vapor 3. This should no longer be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants