Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field<Value> as property wrapper? #42

Closed
zdnk opened this issue Jun 18, 2019 · 4 comments
Closed

Field<Value> as property wrapper? #42

zdnk opened this issue Jun 18, 2019 · 4 comments
Labels
enhancement New feature or request
Projects

Comments

@zdnk
Copy link

zdnk commented Jun 18, 2019

Would it be possible and more friendly to implement fields as property wrappers and also possibly get rid of wrapping every model in Row<>?

@linqingmo
Copy link

maybe you can try property-wrapper branch?

@zdnk
Copy link
Author

zdnk commented Jun 18, 2019

I see. Cool. Looking forward to the final solution :)

@tanner0101 tanner0101 added the enhancement New feature or request label Jun 19, 2019
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Jun 19, 2019
@tanner0101
Copy link
Member

tanner0101 commented Jun 19, 2019

I definitely want to use property wrappers for Field, but as SE-0258 currently stands, the access level limitations will make this difficult. I've written a response that explains why I think this should be changed so that FluentKit can make use of property wrappers:
https://forums.swift.org/t/se-0258-property-wrappers-second-review/25843/14?u=tanner0101

It seems like my response may have been successful, but we still have to wait and see. Any support you could give to my post there would be appreciated!

@tanner0101
Copy link
Member

This was added in #54 :)

Vapor 4 automation moved this from To Do to Done Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Vapor 4
  
Done
Development

No branches or pull requests

3 participants