Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MySQLConfiguration non-constant #211

Closed
0xTim opened this issue Jul 8, 2022 · 6 comments
Closed

Make MySQLConfiguration non-constant #211

0xTim opened this issue Jul 8, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Beginner Issues

Comments

@0xTim
Copy link
Member

0xTim commented Jul 8, 2022

We should allow the configuration in MySQLConfiguration to be changed by changing the properties to vars. This matches Postgres and makes it easier to set things like the TLSConfiguration
@0xTim 0xTim added enhancement New feature or request good first issue Good for newcomers labels Jul 8, 2022
@VaporBot VaporBot added this to To do in Beginner Issues Jul 8, 2022
@lodenrogue
Copy link

I can give this a try

@lodenrogue
Copy link

PR: #212

Please review it. I've never worked with swift before and I have no way to test locally.

@fananek
Copy link

fananek commented Jul 9, 2022 •
edited

I’m afraid you edited wrong file. Issue is about MySQLConfiguration properties.

All these lets shall be changed to vars.

@lodenrogue
Copy link

Got it. I'll make that change

@lodenrogue lodenrogue mentioned this issue Jul 9, 2022
Merged
@lodenrogue
Copy link

PR: vapor/mysql-kit#309

I think a better approach is to just create a new MySQLConfiguration object and keep the fields immutable. But here's the change you requested in case you still want it.

@0xTim
Copy link
Member Author

0xTim commented Jul 22, 2022

Fixed in vapor/mysql-kit#309

@0xTim 0xTim closed this as completed Jul 22, 2022
@VaporBot VaporBot moved this from To do to Done in Beginner Issues Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Beginner Issues
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lodenrogue @0xTim @fananek