Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity columns should only be used on PostgreSQL 10 #6

Closed
vzsg opened this issue Jan 29, 2018 · 1 comment
Closed

Identity columns should only be used on PostgreSQL 10 #6

vzsg opened this issue Jan 29, 2018 · 1 comment
Assignees
@tanner0101
Labels
bug Something isn't working enhancement New feature or request
Milestone
1.0.0-beta.3

Comments

@vzsg
Copy link
Member

vzsg commented Jan 29, 2018

On earlier versions, the current implementation will throw a syntax error.

Either fluent-postgresql should detect which PG version it is connected to, and use that information while generating the column type, or the Identity feature should be opt-in.
@Joannis Joannis added bug Something isn't working enhancement New feature or request labels Jan 29, 2018
This was referenced Feb 16, 2018
Closed
Merged
@tanner0101 tanner0101 added this to the 1.0.0-beta.3 milestone Feb 19, 2018
@tanner0101
Copy link
Member

tanner0101 commented Feb 19, 2018 •
edited 

try services.register(FluentPostgreSQLProvider(enableIdentityColumns: false))

@tanner0101 tanner0101 mentioned this issue Feb 19, 2018
Closed
@tanner0101 tanner0101 added this to Done in Vapor 3 Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanner0101 tanner0101

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.0.0-beta.3
Development

No branches or pull requests
3 participants
@tanner0101 @vzsg @Joannis