Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLOB type should map to Node.bytes, not Node.string #83

Closed
vzsg opened this issue Feb 10, 2017 · 1 comment
Closed

BLOB type should map to Node.bytes, not Node.string #83

vzsg opened this issue Feb 10, 2017 · 1 comment
Assignees
@loganwright
Labels
enhancement New feature or request
Milestone
2.0

Comments

@vzsg
Copy link
Member

vzsg commented Feb 10, 2017

Currently the BLOB column type goes through the same UTF-8 decoding as string types, despite the common definition (incl. MySQL's own) that BLOB (and BINARY and VARBINARY) columns store raw binary data.

I think this type should be mapped to Node.bytes(Bytes) directly, without any encoding in either direction.
@tanner0101
Copy link
Member

@vzsg totally agree. I'm excited about the performance improvements the new bytes case is going to get us.

@tanner0101 tanner0101 added this to the 2.0 milestone Feb 10, 2017
@tanner0101 tanner0101 added the enhancement New feature or request label Feb 10, 2017
@loganwright loganwright mentioned this issue Feb 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loganwright loganwright

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@tanner0101 @vzsg @loganwright