Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing Postgres auth credentials while ConnectionPool is alive #431

Open
fabianfett opened this issue Oct 28, 2023 · 2 comments
Open
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule enhancement New feature or request

Comments

@fabianfett
Copy link
Collaborator

To support password rotation, the ConnectionPool should support rotating auth credentials while running. New connections should be spun up asap and old connections should be closed as once they are returned to the pool and the new connections are up.

@fabianfett fabianfett added enhancement New feature or request ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule labels Oct 28, 2023
@fabianfett
Copy link
Collaborator Author

Original request from @majortom64 in #256:

For security purposes it would be great to support ephemeral database user credentials, generated by something like HashiCorp’s Vault. These credentials timeout and then need to be regenerated. When they change, the Connection Pool would need to automatically close or automatically handle getting the new credentials and updating the connection.

@fabianfett
Copy link
Collaborator Author

In an ideal case, we would likely try to create a new connection with the new properties... And only accept them, if we are able to create a new connection with them. Only once we validated we can actually create new connections with the new properties, we should actually apply them to the pool (aka closing old connections). If we currently can't create connections with the old properties, who cares and we should apply them directly.

@fabianfett fabianfett added this to the ConnectionPool milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ConnectionPool Features and bugs that are related to the impl in ConnectionPoolModule enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant