Add support for connecting to a Postgres database via Unix sockets. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner0101
reviewed
May 30, 2018
| extension PostgreSQLConnection { | ||
| /// Connects to a Redis server using a TCP socket. | ||
| public static func connect( | ||
| hostname: String = "localhost", |
There was a problem hiding this comment.
There needs to be a deprecated method for this old API
| extension PostgreSQLConnection { | ||
| /// Connects to a PostgreSQL server using a TCP socket. | ||
| public static func connect( | ||
| to serverAddress: PostgreSQLDatabaseConfig.ServerAddress = .default, |
There was a problem hiding this comment.
There appears to be a formatting issue here.
There was a problem hiding this comment.
Done, thanks! Fixed whitespace everywhere.
| case unixSocket(path: String) | ||
|
|
||
| public static let `default` = ServerAddress.tcp(hostname: "localhost", port: 5432) | ||
| public static let defaultViaSocket = ServerAddress.unixSocket(path: "/tmp/.s.PGSQL.5432") |
There was a problem hiding this comment.
I think socketDefault would be a fine name here.
| /// Destination port. | ||
| public let port: Int | ||
|
|
||
| public enum ServerAddress { |
|
PTAL |
|
Hey @MrMage, you just merged a pull request, have a coin! You now have 9 coins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy to add a connectivity test as well, but I don't know whether the Postgres DB used in CI is set up for supporting Unix sockets. Let me know if you can provide any insights on that.
Motivation: Unix sockets have lower latency and higher throughput than TCP sockets. There are reports that indicate this to be particularly relevant when using Google Cloud SQL proxy.