Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run in Application's EventLoopGroup for Vapor 3 #34

Closed
Igor-Palaguta opened this issue Aug 7, 2019 · 4 comments
Closed

Run in Application's EventLoopGroup for Vapor 3 #34

Igor-Palaguta opened this issue Aug 7, 2019 · 4 comments

Comments

@Igor-Palaguta
Copy link

It is cool if there is way to customize event loop group for version 0.2.7. Like in new version to reuse application's event loops group

Under hobby account in heroku there is a limit 20 postgres connections for all workers. And JobCommand creates MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount) and every thread creates own connections as I understand correctly. So this limit is easy to reach currently

@jdmcd
Copy link
Member

jdmcd commented Aug 7, 2019

That's a good point. We should make it customizable.

@jdmcd
Copy link
Member

jdmcd commented Aug 8, 2019

FYI - this will be fixed for v1

@jdmcd jdmcd closed this as completed Aug 8, 2019
@Igor-Palaguta
Copy link
Author

v1 is shipped with Vapor 4?
Cool if for Vapor 3 it will also work

@jdmcd
Copy link
Member

jdmcd commented Aug 8, 2019

Right now V1 is targeting Vapor 4, so no, it won't work in Vapor 3. If I get some time later this week or next week though I can make a patch for Vapor 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants