Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative error reporting about what job is failing #81

Open
jhoughjr opened this issue Jul 15, 2020 · 2 comments
Open

More informative error reporting about what job is failing #81

jhoughjr opened this issue Jul 15, 2020 · 2 comments
Labels
enhancement New feature or request
Projects

Comments

@jhoughjr
Copy link

QueuesCommand.swift line 101: worker.queue.logger.error("Job run failed: (error)")
yields uninformative errors like "Connection refused" with no context as to what actually failed.
Logging the worker, I see it has some information about the job that would be useful.

Might relate to #79 possibly as without a delay, the logs fill with infinite retries of non-obvious origins.
Possibly just logging the job might suffice.

@jdmcd
Copy link
Member

jdmcd commented Jul 15, 2020

You can use the error function to customize the error message if you'd like, although I agree that it would be nice to log out the data and other items with trace or debug levels

@jdmcd jdmcd added this to To Do in Vapor 4 via automation Jul 15, 2020
@jhoughjr
Copy link
Author

I added something quick and dirty to see what could be done ie was the condition accessible at runtime. I might ponder it and put in a PR.

@tanner0101 tanner0101 added the enhancement New feature or request label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Vapor 4
  
To Do
Development

No branches or pull requests

3 participants