Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have to name all params the same #90

Closed
grosch opened this issue Apr 4, 2020 · 1 comment
Closed

Have to name all params the same #90

grosch opened this issue Apr 4, 2020 · 1 comment
Labels
bug Something isn't working
Projects
Vapor 4

Comments

@grosch
Copy link

grosch commented Apr 4, 2020

The routing engine is too restrictive on what the parameter fields can be. For example, I tried to create these two routes for a DELETE

orders/:id
orders/:orderID/work/:workID

That fails because the router wants the ':orderID' in the second line to also be called ':id'.

Yes, I can do that of course, but it makes the names not as clear when working with multiple fields.
@grosch grosch added the bug Something isn't working label Apr 4, 2020
@stevapple stevapple mentioned this issue Apr 11, 2020
Closed
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Apr 15, 2020
@tanner0101
Copy link
Member

This is a duplicate of #92

Vapor 4 automation moved this from To Do to Done Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grosch @tanner0101