Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Bool conforming to SQLiteDataConvertible #36

Merged
merged 1 commit into from May 15, 2018

Conversation

eLud
Copy link
Contributor

@eLud eLud commented May 10, 2018

While creating a simple Model using a Bool value, I ran into the following error.

Cannot serialize Bool to SQLiteData

Not sure why this was not implemented yet (maybe this was on purpose), but in case this is not intentional, this pull requests correct the issue by adding conformance to the SQLiteDataConvertible protocol to the Bool type.

Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tanner0101 tanner0101 merged commit 3bbf797 into vapor:master May 15, 2018
@penny-coin
Copy link

Hey @eLud, you just merged a pull request, have a coin!

You now have 1 coins.

tanner0101 added a commit that referenced this pull request Jun 7, 2018
Made Bool conforming to SQLiteDataConvertible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants