Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build script uses deprecated APIs #392

Closed
0xTim opened this issue May 30, 2022 · 1 comment · Fixed by #394
Closed

Build script uses deprecated APIs #392

0xTim opened this issue May 30, 2022 · 1 comment · Fixed by #394
Labels
enhancement New feature or request good first issue help wanted Extra attention is needed
Projects
Help Wanted Issues Beginner Issues

Comments

@0xTim
Copy link
Member

0xTim commented May 30, 2022

The build script for this use (scripts/build.swift) uses deprecated Task APIs. E.g.

scripts/build.swift:48:10: warning: 'launchPath' is deprecated: renamed to 'executableURL'
    task.launchPath = "/usr/bin/env"
         ^
scripts/build.swift:48:10: note: use 'executableURL' instead
    task.launchPath = "/usr/bin/env"
         ^~~~~~~~~~
         executableURL
scripts/build.swift:50:10: warning: 'launch()' is deprecated: renamed to 'run'
    task.launch()
         ^
scripts/build.swift:50:10: note: use 'run' instead
    task.launch()
         ^~~~~~
         run
scripts/build.swift:61:10: warning: 'launchPath' is deprecated: renamed to 'executableURL'
    task.launchPath = "/usr/bin/env"
         ^
scripts/build.swift:61:10: note: use 'executableURL' instead
    task.launchPath = "/usr/bin/env"
         ^~~~~~~~~~
         executableURL
scripts/build.swift:69:10: warning: 'launch()' is deprecated: renamed to 'run'
    task.launch()
         ^
scripts/build.swift:69:10: note: use 'run' instead
    task.launch()
         ^~~~~~
         run

We should fix this
@0xTim 0xTim added enhancement New feature or request help wanted Extra attention is needed good first issue labels May 30, 2022
@VaporBot VaporBot added this to To do in Help Wanted Issues May 30, 2022
@VaporBot VaporBot added this to To do in Beginner Issues May 30, 2022
@roya1v roya1v mentioned this issue Jun 5, 2022
Merged
@ahmdyasser ahmdyasser moved this from To do to Done in Beginner Issues Jun 9, 2022
@ahmdyasser ahmdyasser linked a pull request Jun 9, 2022 that will close this issue
Use new API for build script #394
Merged
@ahmdyasser
Copy link
Member

It's fixed on #394 , I think I can close it now.

@VaporBot VaporBot moved this from To do to Done in Help Wanted Issues Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue help wanted Extra attention is needed
Projects
Beginner Issues
  
Done
Help Wanted Issues
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new API for build script
2 participants
@0xTim @ahmdyasser