Swiftlint autocorrect #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static func withBytes(bytes: ArraySlice<UInt8>) -> Int { | ||
| return Int.withBytes(Array(bytes)) | ||
| } | ||
|
|
There was a problem hiding this comment.
Why all the spacing commits?
|
Looks good to me, I'd prefer to remove the whitespace additions, but I'm not sure it's worth it. I know Xcode will move them back if someone is in the file area and formats. Happy to have some enforced linting!!!
|
from me
|
@loganwright once we turn on houndci (see #162) if anyone screws up, the hound bot will comment in the PR to let you know and the test will fail, so that should protect us from this moving forward. Everyone should probably turn this on in Xcode though: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending #162