Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vapor 2 and swift 4.1 #1659

Closed
Igor-Palaguta opened this issue May 6, 2018 · 5 comments
Closed

Vapor 2 and swift 4.1 #1659

Igor-Palaguta opened this issue May 6, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Igor-Palaguta
Copy link

Thank you for Vapor!

Do you have any plan to adopt Vapor 2 to swift 4.1. It compiles and works fine, but I have like 50 warnings during compilation. Not sure I have time in nearest future to adopt project to Vapor 3. As it changed significantly.

I think a lot of projects will use Vapor 2 for long time. As really Vapor 3 looks like absolutely other framework. And currently there is no instruction/tool how to migrate it. As I see still not all modules (e.g. CSRF) are migrated to Vapor 3.

Sure in future I will migrate. As Vapor 3 looks great. For now, it is good if we can use old one without warnings.

Thanks in advance

@rpinz
Copy link

rpinz commented May 7, 2018

Upgrading Versions

@tanner0101 tanner0101 added the enhancement New feature or request label May 7, 2018
@tanner0101 tanner0101 self-assigned this May 7, 2018
@tanner0101
Copy link
Member

Yes, we should get rid of warnings in Vapor 2. I will look into this, thanks @Igor-Palaguta.

@Igor-Palaguta
Copy link
Author

@tanner0101 Thank you! I promise will migrate to Vapor 3), when I have time. As it is really very cool!

@Igor-Palaguta
Copy link
Author

Hello,

Please can you merge #1690

@MrLotU
Copy link
Sponsor Member

MrLotU commented Jan 30, 2019

Fixed by #1814

@MrLotU MrLotU closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants