New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cascade ws client error to promise #2041

Merged

tanner0101 merged 1 commit into master from ws-test-cascade-failure

Aug 27, 2019

Member

tanner0101 commented Aug 27, 2019 •

edited

Fixes flaky test #2040
Fixes a leaked promise assertion when WebSocket connection fails during test


          cascade ws client error to promise

f7b45ea

tanner0101 added the bug label

tanner0101 added this to In Progress in Vapor 4 via automation

tanner0101 merged commit 098c120 into master

penny-coin commented Aug 27, 2019

Hey @tanner0101, you just merged a pull request, have a coin!

You now have 1369 coins.

Vapor 4 automation moved this from In Progress to Done

tanner0101 deleted the ws-test-cascade-failure branch

August 27, 2019 20:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment