content type fix #209
Merged
content type fix #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| headers["Content-Type"] = Response.Headers.Values(type.description) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| var headers: Response.Headers = [:] | ||
|
|
||
| if | ||
| let fileExtension = filePath.split(byString: ".").last, |
There was a problem hiding this comment.
I always want this to be func split(by string:? Do we own it
There was a problem hiding this comment.
It's from Zewo/String. We can make a PR there.
| @@ -1,4 +1,5 @@ | |||
| import libc | |||
| import MediaType | |||
|
|
|||
| public class Application { | |||
| public static let VERSION = "0.5.3" | |||
There was a problem hiding this comment.
Can you please update the version?
There was a problem hiding this comment.
Oops, yeah. Looks like we've been forgetting to do that. I'll make an issue for the 0.8 release (milestone).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduces content types for a given file extension.
For example:
Fixes #192