Remove unused Validations code #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanner0101
previously approved these changes
Nov 22, 2019
|
@tanner0101 I meant to use tn-core-service as a base. Now it should be ok 🙂 |
- remove ValidatorType - avoid force unwrap - avoid illegal count and range operators by not exposing .range() and .count()
siemensikkema
force-pushed
the
feature/validation-fixes-feedback
branch
from
7f6def8
to
c95dd0e
Compare
|
@tanner0101 I misunderstood, you had already merged tn-core-service into master. I was able to cherry pick my changes and force push so now it should be ok 🙂 |
tanner0101
approved these changes
Mar 6, 2020
tanner0101
changed the title
tanner0101
changed the title
|
These changes are now available in 4.0.0-rc.2 |
pull bot
pushed a commit
to scope-demo/vapor
that referenced
this pull request
Mar 6, 2020
- remove ValidatorType - avoid force unwrap - avoid illegal count and range operators by not exposing .range() and .count()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change since some public API is being removed, but it is not being used anywhere.
ValidatorType