Migrate the crypto library to Swift Crypto #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One alternative approach would be to make "OpenCrypto" fallback to |
|
The issue with that is you still end up maintaining a crypto library which no one really wants to do! |
|
But no one really wants to upgrade to 10.15 either ;) |
|
Nice work @0xTim! The 10.15 requirement is no big deal for me, since I am always on the latest OS version. Ultimately @tanner0101 needs to make the call since he's the one maintaining open-crypto. |
|
Forum post about removing support for 10.14 is here |
vzsg
changed the title
This was referenced Feb 21, 2020
tanner0101
approved these changes
Feb 26, 2020
|
These changes are now available in 4.0.0-beta.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from Vapor's OpenCrypto library to Apple's new Swift Crypto library. This reduces the burden on Vapor on having to maintain a crypto library and completely removes OpenSSL as a dependency 馃帀
The downside of this is that Vapor 4 will require macOS 10.15, but the tradeoff is worth it.