Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WebSocket maxFrameSize to be configured #2194

Closed
bridger opened this issue Feb 23, 2020 · 2 comments · Fixed by #2195
Closed

Allow WebSocket maxFrameSize to be configured #2194

bridger opened this issue Feb 23, 2020 · 2 comments · Fixed by #2195
Labels
enhancement New feature or request
Projects

Comments

@bridger
Copy link
Contributor

bridger commented Feb 23, 2020

Today the NIOWebSocketServerUpgrader is always created with the same maxFrameSize of 1 << 14 (16kb). My app regularly sends larger frames to the server, which is causing the server to reject them.

I'd like to add a configuration parameter when setting up the route to allow larger frames. The configuration can also be used for future features, such as enabling compression or starting automatic ping/pong heartbeats.

I plan to submit a PR soon to create this feature.

@tanner0101 tanner0101 added the enhancement New feature or request label Feb 26, 2020
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Feb 26, 2020
@lmcd
Copy link

lmcd commented Feb 27, 2020

I'm also running into this. WebSocket connection is closing on me if I send anything over 16kb

@bridger
Copy link
Contributor Author

bridger commented Feb 27, 2020

I hope to get this merged in soon! There is a different PR to be merged first, and then I can update this fix maybe tonight.

Sent with GitHawk

@tanner0101 tanner0101 moved this from Backlog to Awaiting Updates in Vapor 4 Mar 6, 2020
Vapor 4 automation moved this from Awaiting Updates to Done Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Vapor 4
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants