Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated configureHTTP2SecureUpgrade. #2261

Merged
merged 2 commits into from Mar 24, 2020

Conversation

jshier
Copy link
Contributor

@jshier jshier commented Mar 22, 2020

Fixes a deprecation warning from swift-nio-http2 requiring version 1.11.0 (#2261).

Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the required minimum version in the package.swift?
https://github.com/vapor/vapor/blob/master/Package.swift#L39

@jshier
Copy link
Contributor Author

jshier commented Mar 24, 2020

@Joannis Updated.

@tanner0101 tanner0101 added the enhancement New feature or request label Mar 24, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Mar 24, 2020
@tanner0101 tanner0101 added the semver-minor Contains new API label Mar 24, 2020
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tanner0101 tanner0101 merged commit 8905787 into vapor:master Mar 24, 2020
Vapor 4 automation moved this from Awaiting Review to Done Mar 24, 2020
@tanner0101
Copy link
Member

These changes are now available in 4.0.0-rc.3.8

@jshier jshier deleted the fix-channelpipeline-deprecation branch March 24, 2020 18:59
pull bot pushed a commit to scope-demo/vapor that referenced this pull request Mar 24, 2020
* Use non-deprecated configureHTTP2SecureUpgrade.

* Require nio-http2 1.11.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-minor Contains new API
Projects
Vapor 4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants