New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for string interpolation to URI #2442
Add support for string interpolation to URI #2442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a problem with this. CC @tanner0101, was there a specific reason not to do this? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a problem with this. CC @tanner0101, was there a specific reason not to do this? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @dimitribouniol. Two things:
- Would you mind adding a test? Just to make sure we don't accidentally lose this conformance if a refactor happens.
- Please format PR title / body as release notes: https://github.com/vapor/vapor/blob/master/.github/contributing.md#releases
…olation so URIs can be expressed with interpolation.
fdb338f
to
6308207
Compare
@tanner0101 I've added to an existing test for URI parsing (for string interpolation too), and reformatted the PR's title and body. Please let me know if it needs any more changes! (I'll do the same to vapor/routing-kit#101 since it's pretty much the same PR, but for PathComponent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
These changes are now available in 4.23.0 |
@tanner0101 Thank you! |
Enables call sites that use URIs to allow for string literals that make use of interpolation (#2442).