Fix Swift 5.3 trailing closure warnings #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Round 2 using a different method. This fixes forward scan trailing closure matching with response-only overload. As recommended by Holly on Swift forums and Grundoon. Thanks! |
tanner0101
added
enhancement
Mordil
approved these changes
Sep 18, 2020
|
@tanner0101 Do we know what's causing the thread sanitizer failures? |
|
Ah, it looks like the compiler failed to capture that it was going to recursively call itself because of the function signature. I've added a commit that fixes this |
MrLotU
approved these changes
Sep 21, 2020
|
These changes are now available in 4.29.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes warnings about trailing closure matching behavior changes in Swift 5.3 (#2485, #2484).