Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .jsonAPI media types for decoding content #2486

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Conversation

Joannis
Copy link
Member

@Joannis Joannis commented Aug 31, 2020

When communicating with API's following the JSON API format, these API's emit a content-type of vnd.api+json. This content type is always used with JSON formatted responses, although they follow a certain JSON format. I think it's therefore helpful to provide a default encoder/decoder for this media type.

I'm not sure if this would be a semver-patch or semver-minor as it's additive behaviour but doesn't touch public API.

Base automatically changed from master to main March 12, 2021 02:50
@Joannis Joannis requested review from 0xTim and gwynne March 22, 2021 08:58
@Joannis
Copy link
Member Author

Joannis commented Mar 22, 2021

@0xTim and @gwynne while looking through PRs I found my own one still open. Care for a small review?

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I'd just do semver-patch for the version.

@0xTim 0xTim added the semver-patch Internal changes only label Mar 23, 2021
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xTim 0xTim merged commit 984852e into main Mar 23, 2021
@0xTim 0xTim deleted the jo-json-api-content branch March 23, 2021 15:44
@VaporBot
Copy link
Contributor

These changes are now available in 4.41.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants