Fix crash in DotEnv parser #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antoinepalazzolo could you update the code so it can be merged? |
|
Additionally if you could update the description of the PR - that will become the release notes for the release. Thanks! |
antoinepalazzolo
force-pushed
the
fix_dotenv_infinite_loop
branch
from
644c6ca
to
a0b6c6b
Compare
antoinepalazzolo
changed the title
…there is no trailling new line
antoinepalazzolo
force-pushed
the
fix_dotenv_infinite_loop
branch
from
a0b6c6b
to
2f7abbc
Compare
|
These changes are now available in 4.36.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when .env file with a comment as the last line was parsed, an infinite recursive loop crashed the application.
The comment is now properly skipped.