Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform MultipartError to AbortError #2575

Merged
merged 2 commits into from Mar 2, 2021
Merged

Conform MultipartError to AbortError #2575

merged 2 commits into from Mar 2, 2021

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Mar 2, 2021

Conform MultipartError to AbortError so that failing requests return a sensible status code to the client, instead of an internal server error.

Resolves #2573

@0xTim 0xTim added the semver-patch Internal changes only label Mar 2, 2021
gwynne
gwynne approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .notImplemented makes more sense than .unprocessableEntity, because the input is valid and can be processed, the code to do it just isn't there.

@0xTim 0xTim merged commit 2bac08a into master Mar 2, 2021
@0xTim 0xTim deleted the multipart-errors branch March 2, 2021 08:23
@tanner0101
Copy link
Member

These changes are now available in 4.41.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siemensikkema siemensikkema siemensikkema approved these changes

@gwynne gwynne gwynne approved these changes

@Joannis Joannis Joannis approved these changes

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultipartError always has HTTP status of 500
5 participants
@0xTim @tanner0101 @siemensikkema @gwynne @Joannis