Fix: URLEncodedFormDecoder ignores empty value when decoding Array #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
approved these changes
Mar 22, 2021
| }) | ||
| self.values = try values.flatMap { value in | ||
| try value.asUrlEncoded().split(omittingEmptySubsequences: false) { | ||
| configuration.arraySeparators.contains($0) |
There was a problem hiding this comment.
LGTM, but I've got I feel like we should change this to:
split(omittingEmptySubsequences: false, whereSeparator: configuration.arraySeparators.contains)
|
These changes are now available in 4.41.10 |
ky1vstar
added a commit
to ky1vstar/URLEncodedFormKit
that referenced
this pull request
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
URLEncodedFormDecoderdecodesarray[]=a&array[]=&array[]=b&array[]=, empty values are ignored and we get incorrect result["a", "b"].After this change the result will be
["a", "", "b", ""].