Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stack trace to RouteNotFound error to improve DebuggableError conformance #2596

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Add stack trace to RouteNotFound error to improve DebuggableError conformance #2596

merged 2 commits into from
Apr 7, 2021

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Mar 31, 2021

Adds a stacktrace to the RouteNotFound error so that error reporting tools have access to it.

Resolves #2532

@0xTim 0xTim added the semver-patch Internal changes only label Mar 31, 2021
madsodgaard
madsodgaard approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@madsodgaard madsodgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:)

@0xTim 0xTim merged commit 18dcf59 into main Apr 7, 2021
@0xTim 0xTim deleted the notFoundError-stack-trace branch April 7, 2021 06:47
@VaporBot
Copy link
Contributor

VaporBot commented Apr 7, 2021

These changes are now available in 4.41.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsodgaard madsodgaard madsodgaard approved these changes

@gwynne gwynne Awaiting requested review from gwynne gwynne is a code owner

@siemensikkema siemensikkema Awaiting requested review from siemensikkema

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RouteNotFound error does not provide stack trace
3 participants
@0xTim @VaporBot @madsodgaard