Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds optional completion handler for FileIO.streamFile #2609

Merged
merged 2 commits into from
May 5, 2021

Conversation

trametheka
Copy link
Contributor

@trametheka trametheka commented Apr 26, 2021

This adds an optional completion handler to FileIO's streamFile(at:chunkSize:mediaType:onCompleted:) which is called when the stream completes writing the response. (#2609)

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@0xTim
Copy link
Member

0xTim commented May 5, 2021

@trametheka could you update your branch (for some reason GH won't let be auto update the branch) and then we're good to merge!

@0xTim 0xTim added the semver-minor Contains new API label May 5, 2021
@trametheka
Copy link
Contributor Author

@0xTim try now

@0xTim 0xTim changed the title Adds optional completion handler for FileIO.streamFile Adds optional completion handler for FileIO.streamFile May 5, 2021
@0xTim 0xTim merged commit 07a105b into vapor:main May 5, 2021
@VaporBot
Copy link
Contributor

VaporBot commented May 5, 2021

These changes are now available in 4.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants