Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate HEAD routes instead of forwarding to GET route handler #2614

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Create separate HEAD routes instead of forwarding to GET route handler #2614

merged 1 commit into from
Apr 29, 2021
+73 −2

Conversation

owainhunt
Copy link
Contributor

Instead of converting HEAD requests to GET requests, register a separate HEAD route for routes with all-constant paths that returns a 200 (#2492)

Instead of converting HEAD requests to GET requests, register a separ…
f7c92ec 
…ate HEAD route for routes with all-constant paths that returns a 200
@owainhunt
Copy link
Contributor Author

@0xTim FYI, this is a recreation of #2496 that was caught up in a combination of the branch renaming script and me deleting the original branch.

0xTim
0xTim approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@0xTim 0xTim added the semver-patch Internal changes only label Apr 28, 2021
@0xTim 0xTim linked an issue Apr 29, 2021 that may be closed by this pull request
HEAD requests to routes that require query parameters can't be correctly responded to #2492
Closed
@0xTim 0xTim merged commit 611c08d into vapor:main Apr 29, 2021
@VaporBot
Copy link
Contributor

These changes are now available in 4.44.3

@trametheka trametheka mentioned this pull request Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HEAD requests to routes that require query parameters can't be correctly responded to
3 participants
@owainhunt @VaporBot @0xTim