Removing redundant call to beforeEncode() hook
#2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Strobocop I haven't forgotten this it's on my todo list. Need to look into why the tests are failing for a simple change |
calebkleveter
approved these changes
Oct 6, 2021
|
@0xTim @calebkleveter Thanks for looking into this. If there was something wrong on my end please let me know so I can avoid causing any future issues any time I submit a PR. To be honest I hadn't tested on linux as I don't have docker running on this machine right now. Given how simple the change was, and that I didn't see anything that looked like it would cause linux specific issues, I assumed the tests I ran on macOS would suffice this once. |
|
@Strobocop It's not your fault, somethings broken with an unrelated test I need to get that fixed |
0xTim
changed the title
beforeEncode() hook
|
These changes are now available in 4.49.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encoding content with the default content type, there was a redundant call to the
beforeEncode()hook. This removes that unnecessary call.