Add a new test method to XCTApplicationTester returns a response directly #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…THTTPResponse directly
tonyarnold
force-pushed
the
response-returning-test
branch
from
f8af78e
to
ab43bc3
Compare
|
Why not |
|
Thanks, Tim - I'll propose that in the PR. I'm not familiar with naming standards in Vapor, so I appreciate the suggestion! |
|
These changes are now available in 4.52.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm finding that there are a few places where having my tests return an XCTHTTPResponse directly — rather than via a closure — feels more ergonomic in use (especially inline with async/await code).
This PR proposes to add a method that does that.
I'm not sold on the name I've given this method (
performTest(…)), so please feel free to suggest alternatives.