Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Response inline comments #2756

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Update Response inline comments #2756

merged 2 commits into from
Jan 7, 2022

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Jan 5, 2022

No description provided.

Sources/Vapor/Response/Response.swift Outdated Show resolved Hide resolved
Sources/Vapor/Response/ResponseCodable.swift Outdated Show resolved Hide resolved
Sources/Vapor/Response/Response.swift Outdated Show resolved Hide resolved
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as @stevapple 's comments are resolved, I'm good 馃憤

Co-authored-by: YR Chen <stevapple@icloud.com>
Copy link
Sponsor Contributor

@stevapple stevapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now馃憤

@0xTim 0xTim added the no-release-needed Doesn't require a release label Jan 7, 2022
@0xTim
Copy link
Member Author

0xTim commented Jan 7, 2022

No code changes and not critical docs, so we'll roll this out in the next release

@0xTim 0xTim merged commit 28d9892 into main Jan 7, 2022
@0xTim 0xTim deleted the response-comments branch January 7, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release-needed Doesn't require a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants