Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTTPServer.init and Middleware.resolve public #2761

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

samisuteria
Copy link
Contributor

@samisuteria samisuteria commented Jan 16, 2022

Make Middlewares.resolve() public to allow users to create their own Responders (#2762)
Add a public initializer to HTTPServer to allow users to create heir own instance (#2761)

@0xTim
Copy link
Member

0xTim commented Jan 18, 2022

@samisuteria what's the use case for needing to create an HTTPServer yourself?

@samisuteria
Copy link
Contributor Author

I'm running both a GRPCServer and HTTPServer at the same time on different ports. I created my own server that implements Vapor.Server protocol and that class needs access to HTTPServer.init.

@0xTim 0xTim added the semver-minor Contains new API label Jan 26, 2022
@0xTim 0xTim changed the title Change HTTPServer.init to public Make HTTPServer.init and Middleware.resolve public Jan 26, 2022
@0xTim 0xTim merged commit 18e9419 into vapor:main Jan 26, 2022
@VaporBot
Copy link
Contributor

These changes are now available in 4.55.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor Contains new API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants